Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add citation #194

Merged
merged 2 commits into from
Jan 19, 2024
Merged

docs: add citation #194

merged 2 commits into from
Jan 19, 2024

Conversation

roedoejet
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4d5cf80) 87.04% compared to head (03477d2) 87.04%.

❗ Current head 03477d2 differs from pull request most recent head de76f97. Consider uploading reports for the commit de76f97 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   87.04%   87.04%           
=======================================
  Files          21       21           
  Lines        1744     1744           
  Branches      315      315           
=======================================
  Hits         1518     1518           
  Misses        189      189           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 17, 2024

CLI load time: 0:00.33
Pull Request HEAD: de76f970b86d566c3b4c89cf0995da023b3aab87
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:    277534 |     336562 | pkg_resources

Copy link
Member

@joanise joanise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@joanise
Copy link
Member

joanise commented Jan 17, 2024

Actually, I have one suggested change: the author and editor fields for BEA are wrapped over many lines, so this will end up being a large block at the bottom of the README when we view it. Since code blocks get horizontal scroll bars and a bibtex entry is not primarily meant for human consumption, I would prefer to unwrap those two fields here and in Web-C.

README.md Outdated Show resolved Hide resolved
@joanise joanise merged commit 777bf47 into main Jan 19, 2024
4 checks passed
@joanise joanise deleted the dev.citation branch January 19, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants